This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Check the HTT bit before counting logical threads
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: "H.J. Lu" <hongjiu dot lu at intel dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 17 May 2016 11:47:51 -0700
- Subject: Re: [PATCH] Check the HTT bit before counting logical threads
- Authentication-results: sourceware.org; auth=none
- References: <20160517180257 dot GA27253 at intel dot com> <87wpms3538 dot fsf at linux-m68k dot org>
On Tue, May 17, 2016 at 11:35 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>
>> diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
>> index 8408624..09113ba 100644
>> --- a/sysdeps/x86/cacheinfo.c
>> +++ b/sysdeps/x86/cacheinfo.c
>> @@ -506,6 +506,11 @@ init_cacheinfo (void)
>> shared = core;
>> }
>>
>> + /* A value of 0 for the HTT bit indicates there is only a single
>> + logical processor. */
>> + if (!HAS_CPU_FEATURE (HTT))
>> + goto intel_no_threads;
>
> Why goto?
>
I want to keep the change as small as possible. I can convert goto
now, later or never. I don't have a preference on it.
--
H.J.