This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] libc-compat.h for <bits/fcntl-linux.h>

From: Mike Frysinger <vapier at gentoo dot org>
To: Eric Neblock <ceneblock at member dot fsf dot org>
Cc: Zack Weinberg <zackw at panix dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 9 May 2016 13:38:42 -0400
Subject: Re: [PATCH] libc-compat.h for <bits/fcntl-linux.h>
Authentication-results: sourceware.org; auth=none
References: <589a6293-be0f-4b55-3a0b-2c180773ad94 at member dot fsf dot org> <CAKCAbMiRMSuMwRcMKLpY9Zu8OB-4zZmQZRUVD7h=z5jca1SQyg at mail dot gmail dot com> <573087FB dot 30607 at member dot fsf dot org> <CAKCAbMh8QrPjtZ=BkkqzX2RYTgOvffkYCz0aScLp8nJgnihNBQ at mail dot gmail dot com> <57308A53 dot 60903 at member dot fsf dot org>

On 09 May 2016 08:02, Eric Neblock wrote:
> On 05/09/2016 07:53 AM, Zack Weinberg wrote:
> > On Mon, May 9, 2016 at 8:52 AM, Eric Neblock <ceneblock@member.fsf.org> wrote:
> >> On 05/09/2016 07:47 AM, Zack Weinberg wrote:
> >>> Rather than this approach, why not have the glibc header include the
> >>> uapi header and rely on its definitions?  This might need to be
> >>> conditional on a sufficiently new version of the uapi header being
> >>> available, but it is more future-proof.
> >>
> >> My only concern with that would be if someone is compiling for BSD,
> >> Solaris, Cygwin, or some other *nix.
> > 
> > In that case, sysdeps/unix/sysv/linux/bits/fcntl-linux.h will not be
> > used at all.
> 
> Just for my own sanity, I rechecked the INSTALL file of glibc and Linux
> headers are required.

well, they're required if you're building for a Linux target.
they aren't needed if you build for non-Linux targets.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] libc-compat.h for <bits/fcntl-linux.h>
  - From: Eric Neblock
- Re: [PATCH] libc-compat.h for <bits/fcntl-linux.h>
  - From: Zack Weinberg
- Re: [PATCH] libc-compat.h for <bits/fcntl-linux.h>
  - From: Eric Neblock
- Re: [PATCH] libc-compat.h for <bits/fcntl-linux.h>
  - From: Zack Weinberg
- Re: [PATCH] libc-compat.h for <bits/fcntl-linux.h>
  - From: Eric Neblock

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]