This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] tst-fmon/tst-numeric: switch malloc to static stack space [BZ #19671]
- From: Mike Frysinger <vapier at gentoo dot org>
- To: libc-alpha at sourceware dot org
- Date: Fri, 22 Apr 2016 17:12:38 -0400
- Subject: [PATCH] tst-fmon/tst-numeric: switch malloc to static stack space [BZ #19671]
- Authentication-results: sourceware.org; auth=none
The current test code doesn't check the return value of malloc.
This should rarely (if ever) cause a problem, but rather than add
some return value checks, just statically allocate the buffer on
the stack. This will never fail (or if it does, we've got much
bigger problems that don't matter to the test).
Checked that the tests still pass on x86_64-linux-gnu.
---
localedata/tst-fmon.c | 2 +-
localedata/tst-numeric.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/localedata/tst-fmon.c b/localedata/tst-fmon.c
index 995cf90..1359775 100644
--- a/localedata/tst-fmon.c
+++ b/localedata/tst-fmon.c
@@ -40,7 +40,7 @@
int
main (int argc, char *argv[])
{
- char *s = malloc (201);
+ char s[201];
if (setlocale (LC_MONETARY, argv[1]) == NULL)
{
diff --git a/localedata/tst-numeric.c b/localedata/tst-numeric.c
index 46a6b48..ac06965 100644
--- a/localedata/tst-numeric.c
+++ b/localedata/tst-numeric.c
@@ -41,7 +41,7 @@
int
main (int argc, char *argv[])
{
- char *s = malloc (201);
+ char s[201];
double val;
/* Make sure to read the value before setting of the locale, as
--
2.7.4