This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedata: CLDRv29: update LC_TIME week/first_week,workday fields
- From: Chris Leonard <cjlhomeaddress at gmail dot com>
- To: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 22 Apr 2016 15:42:42 -0400
- Subject: Re: [PATCH] localedata: CLDRv29: update LC_TIME week/first_week,workday fields
- Authentication-results: sourceware.org; auth=none
- References: <1460791597-25633-1-git-send-email-vapier at gentoo dot org> <20160422192913 dot GD5369 at vapier dot lan>
I can't pretend that I have gone through the details or done any of my
own due diligence, but I am inclined to endorse as a good-faith
effort. I must admit it feels like a scary large (cross-cutting)
patch and on a field that frequently draws complaints, but I don't
think that an incremental approach would serve any purpose in this
case, so perhaps it is best to just rip off the band-aid all-at-once
and see what happens to people's calendar programs out there. It
could either cause a big sigh of relief or absolute mayhem for end
users, but I think it is going to be fairly visible, so we should hear
back one way or the other.
cjl
On Fri, Apr 22, 2016 at 3:29 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 16 Apr 2016 03:26, Mike Frysinger wrote:
>> I've spot checked a number of these, including some that were def
>> wrong (like ff_SN). It also fixes all open week-related bugs.
>>
>> Since ff_SN is the only one that changes its base date, I also made
>> sure that its ordering of day translations were correct. Looks like
>> another case Petr brought up where the week field was not actually
>> checked against the day arrays.
>>
>> I also took the opportunity to drop first_weekday/first_workday when
>> the value aligned with the defaults (1 & 2 respectively). This didn't
>> impact too many locales In practice because the majority omitted them
>> already.
>
> any takers on this or the other localedef week patch ? :)
> -mike