This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH mtd-utils] include sys/sysmacros.h for major/minor/makedev

On 18 Apr 2016 09:39, Brian Norris wrote:
> On Sat, Apr 16, 2016 at 10:30:45PM -0400, Mike Frysinger wrote:
> > These functions have always been defined in sys/sysmacros.h under
> > Linux C libraries.  For some, including sys/types.h implicitly
> > includes that as well, but glibc wants to deprecate that, and some
> > others already have.  Include the header explicitly for the funcs.
> > 
> > Signed-off-by: Mike Frysinger <>
> Patch looks fine to me, thanks. Pushed to mtd-utils.git.
> But I don't see this change documented anywhere. (Helpfully, I do see
> the change from your other patch -- _BSD_SOURCE -> _DEFAULT_SOURCE --
> documented though!) Should the man-pages project be updated? I see the
> latest makedev(5) still recommends #include <sys/types.h>.

glibc hasn't moved forward (yet).  we should update the man pages now
though to mention sys/sysmacros.h.

Attachment: signature.asc
Description: Digital signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]