This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/4] Consolidate pread/pread64 implementations
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org, Adhemerval Zanella <adhemerval dot zanella at linaro dot com>
- Date: Thu, 14 Apr 2016 20:54:38 +0200
- Subject: Re: [PATCH 3/4] Consolidate pread/pread64 implementations
- Authentication-results: sourceware.org; auth=none
- References: <1456431555-14182-1-git-send-email-adhemerval dot zanella at linaro dot org> <1456431555-14182-4-git-send-email-adhemerval dot zanella at linaro dot org>
On 02/25/2016 09:19 PM, Adhemerval Zanella wrote:
From: Adhemerval Zanella<adhemerval.zanella@linaro.com>
This patch consolidates all the pread/pread64 implementation for Linux
in only one (sysdeps/unix/sysv/linux/pread.c). It also removes the
syscall from the auto-generation using assembly macros.
This may have broken pread and pread64 on 32-bit arm. I'm trying to get
more details.
FAIL: debug/tst-chk1
FAIL: debug/tst-chk2
FAIL: debug/tst-chk3
FAIL: debug/tst-chk4
FAIL: debug/tst-chk5
FAIL: debug/tst-chk6
FAIL: debug/tst-lfschk1
FAIL: debug/tst-lfschk2
FAIL: debug/tst-lfschk3
FAIL: debug/tst-lfschk4
FAIL: debug/tst-lfschk5
FAIL: debug/tst-lfschk6
FAIL: posix/tst-preadwrite
FAIL: posix/tst-preadwrite64
The debug/* failures have:
Failure on line 1006
Failure on line 1009
Failure on line 1013
Failure on line 1032
Failure on line 1035
Failure on line 1039
Also corresponding to pread, pread64.
Florian