This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5] Add pretty printers for the NPTL lock types


On Tue, Apr 12, 2016 at 11:55:39AM -0300, Martin Galvan wrote:
> Right? What about lines where both the function and the parameters are so long
> that they can't be reasonably split? E.g.

Write them outside the condition, i.e.

    ret = pthread_rwlockattr_setkind_np (attr,
					 PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP);

and test RET instead or use a macro as Roland suggested.  You could do
it throughout the test for uniformity instead of doing it just to
escape from the line wrapping complication.

Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]