This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v5] Add pretty printers for the NPTL lock types
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Martin Galvan <martin dot galvan at tallertechnologies dot com>, libc-alpha at sourceware dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>, Carlos O'Donell <carlos at redhat dot com>, Tom Tromey <tom at tromey dot com>
- Date: Tue, 12 Apr 2016 11:28:47 +0530
- Subject: Re: [PATCH v5] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1460405322-31278-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160411203830 dot EF45B2C3B22 at topped-with-meat dot com> <CAOKbPbYmtfq=qReDNhTkVgt64cSbsd=+VQ+rHAgigdfbhBdMcQ at mail dot gmail dot com> <20160411213057 dot 92EE82C3B22 at topped-with-meat dot com> <CAOKbPbausROA=TM1K8Up=ttc9sHxaLtBWUsi7KPxDiS77+Jiig at mail dot gmail dot com> <20160411221656 dot 65CB82C3B38 at topped-with-meat dot com> <20160412030324 dot GE30851 at devel dot intra dot reserved-bit dot com>
On Tue, Apr 12, 2016 at 08:33:25AM +0530, Siddhesh Poyarekar wrote:
> So you're only suggesting moving nptl-printers.py to nptl, which seems
> fine given that it is specific to nptl. That does not conflict with
> my insistence to have a subdir for pretty-printers because my
> intention was to make it the destination for common code. I did not
> pay attention to what *should't* go into pretty-printers, which I now
> realize I should have.
I just looked at my original email and I admit that I had suggested
putting all pretty printers code into a separate directory and not
just the common code. That does not make sense given our current code
layout and it does make more sense to keep common code and tests in
pretty-printers, while keeping module-specific code in their module
directories.
Siddhesh