This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING][PATCH v4] Add pretty printers for the NPTL lock types
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- Cc: libc-alpha at sourceware dot org, Carlos O'Donell <carlos at redhat dot com>, Tom Tromey <tom at tromey dot com>, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Mon, 11 Apr 2016 18:55:37 +0530
- Subject: Re: [PING][PATCH v4] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1459775243-3092-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160410063730 dot GB30851 at devel dot intra dot reserved-bit dot com> <CAOKbPbZOJxAM0tQmzaG1e_fHNx2QG1Rss553nYZN-0k5f2_VKw at mail dot gmail dot com> <20160411032629 dot GC30851 at devel dot intra dot reserved-bit dot com> <CAOKbPbZ_fYTP_-BPg+8X5-sbKr-AWyHKFOwQjH0rjgo48C6=-A at mail dot gmail dot com>
On Mon, Apr 11, 2016 at 10:04:54AM -0300, Martin Galvan wrote:
> If the file was created from pretty-printers, I'd have to add
> something to the pretty-printers Makefile to (again) traverse all the
> submodule dirs, which is ugly. I guess I could add an 'mkdir -p
> $(common-objpfx)/pretty-printers' to the $(py-const) recipe, which is
> a bit better though it'd try to create the dir each time Makerules
> runs for a submodule with gen-py-const-headers. I can only pray that
> whatever part of the build system that's creating the submodule dirs
> is using '-p' as well, or else it'll fail when it arrives to
> pretty-printers..
I think there's a make-target-directory or similar macro in Makerules
that ought to help you achieve this. IIRC it skips creating the
target directory if it exists or at least does not fail
catastrophically.
Siddhesh