Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation

["Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>]

Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:

> On 30-03-2016 15:14, Tulio Magno Quites Machado Filho wrote:
>> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>> 
>>> On 30-03-2016 10:14, Tulio Magno Quites Machado Filho wrote:
>>>> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
>>>>
>>>>> 	* sysdeps/powerpc/powerpc64/strcspn.S: Remove file.
>>>>> 	* sysdeps/powerpc/powerpc64/strpbrk.S: Likewise.
>>>>
>>>> But the removal of these 2 brings some serious performance degradation.
>>>> I think we should keep them for now.
>>>
>>> Do you mean regression on POWER7 only or for POWER8 as well? 
>> 
>> Both.
>> 
>>> And what do you mean by 'serious'?
>> 
>> The new strcspn C implementation spent 8x the time of the powerpc64 assembly.
>> While strpbrk spent ~12x the time.
>> Using the benchtests.
>> 
>
> This is definitively not what I am seeing the environment I am using
> (powerpc64le, POWER8E (raw), 3.5GHz, --with-cpu=power7, CFLAGS=-O3,
> gcc 4.8.4).
> I am sending you the benchtests data in attachment.

I'm sorry for the unnecessary noise.
I found the problem here between the chair and the keyboard.  :-D

The whole patch LGTM now.

Thanks!

-- 
Tulio Magno