This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nsswitch: Add group merging support
- From: Florian Weimer <fweimer at redhat dot com>
- To: Stephen Gallagher <sgallagh at redhat dot com>, libc-alpha at sourceware dot org
- Date: Tue, 29 Mar 2016 07:07:11 +0200
- Subject: Re: [PATCH] nsswitch: Add group merging support
- Authentication-results: sourceware.org; auth=none
- References: <568A7D3A dot 7060500 at redhat dot com> <1451916736-2222-1-git-send-email-sgallagh at redhat dot com> <20160322004020 dot GZ6588 at vapier dot lan> <56F936A3 dot 2020907 at redhat dot com> <20160328194011 dot GX6588 at vapier dot lan>
On 03/28/2016 09:40 PM, Mike Frysinger wrote:
> On 28 Mar 2016 09:50, Stephen Gallagher wrote:
>> On 03/21/2016 08:40 PM, Mike Frysinger wrote:
>>> On 04 Jan 2016 09:12, Stephen Gallagher wrote:
>>>> +a match, the behavior is undefined. + else + { +
>>>> no_more = __nss_next2 (nip, func_name, NULL, &fct.ptr,
>>>> status, 0); + }
>>>
>>> could elide the braces
>>
>> I am aware, but my personal preference is to always have braces
>> even for single-line IF/ELSE blocks (helps avoid merge issues
>> like the famous Apple GOTO bug).
GNU style requires omitting the braces.
> w/gcc-6 coming down the pike, i'd rather just go with relying on
> the new warning flag about misleading indentation.
GCC 6 only warns about misleading additional indentation, not missing
indentation:
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66298>
So we aren't quite there yet.
Florian