This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Date: Mon, 28 Mar 2016 14:56:38 -0300
- Subject: Re: [PATCH 4/4] Remove powerpc64 strspn, strcspn, and strpbrk implementation
- Authentication-results: sourceware.org; auth=none
- References: <1459178389-14133-1-git-send-email-adhemerval dot zanella at linaro dot org> <1459178389-14133-5-git-send-email-adhemerval dot zanella at linaro dot org> <56F95707 dot 8060202 at linux dot vnet dot ibm dot com>
On 28-03-2016 13:08, Paul E. Murphy wrote:
> Hi Adhemerval,
>
> Thanks for commonizing that. I'm surprised it hasn't been done earlier.
>
> Anyhow, coincidental timing. I posted https://sourceware.org/ml/libc-alpha/2016-03/msg00642.html
> friday to optimize strspn with vector bit permutes. We'll need to coordinate
> these patches.
>
> Thanks,
> Paul
>
Indeed, however a fix is just by adjusting
sysdeps/powerpc/powerpc64/multiarch/strspn-ppc64.{s,c} like:
---
#include <string.h>
#define STRSPN __strspn_ppc
#undef libc_hidden_builtin_def
#define libc_hidden_builtin_def(name)
extern __typeof (strspn) __strspn_ppc;
#include <string/strspn.c>
---