This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Copy x86_64 _mcount.op from _mcount.o
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Paul Pluzhnikov <ppluzhnikov at google dot com>
- Date: Thu, 3 Mar 2016 16:10:16 -0800 (PST)
- Subject: Re: [PATCH] Copy x86_64 _mcount.op from _mcount.o
- Authentication-results: sourceware.org; auth=none
- References: <20160303134500 dot GA18701 at intel dot com>
I don't understand why you thought this was a change that should go in
immediately without review.
No change that introduces a new variable to the protocol between generic
makefiles and sysdeps/.../Makefile fragments should go in without review.
This is not at all in the "obvious enough" category, so I really don't
see any justification for committing it without waiting a normal amount
of time for normal review.
The burden is always on you to justify why normal review can be skipped.
I should not need to give you reasons why it should not have been skipped.
If I'd had a chance to review this change, I'd have said that I don't see
any adequate rationale for this change. You said it was a no-op change, so
clearly it was not actually needed for anything. I don't think the trivial
amount of build time added by assembling one small file is anywhere near
adequate to justify the maintenance burden of a fiddly makefile change like
this.