This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #19490] Add unwind descriptors for x86_64 _mcount and __fentry__
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Wed, 2 Mar 2016 20:20:16 -0800
- Subject: Re: [PATCH][BZ #19490] Add unwind descriptors for x86_64 _mcount and __fentry__
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobPzA=QaRyua2KVLR5CtKoks_Tz=c45SwWBg18sY0X4kWg at mail dot gmail dot com> <20160222091457 dot GJ19841 at vapier dot lan> <CALoOobMWtqPyM99G4mX56nV=ymqNGFKEwWMAmc0h_Uff_K2yjA at mail dot gmail dot com> <20160226034043 dot GM19841 at vapier dot lan> <CALoOobMtV8tWzW5rxU-UUN0Q7Pc3TCVUpfXXr3kOUoodr+0n0w at mail dot gmail dot com> <CAMe9rOpAgpdPTPz7ac_kyfkCG19YQwQTyhQzPRWuN8BEg5aS-Q at mail dot gmail dot com>
On Wed, Mar 2, 2016 at 7:44 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> Can you also update it to use ENTRY/END?
In sysdeps/x86_64/sysdep.h:
/* Define an entry point visible from C. */
#define ENTRY(name) \
.globl C_SYMBOL_NAME(name); \
.type C_SYMBOL_NAME(name),@function; \
.align ALIGNARG(4); \
C_LABEL(name) \
cfi_startproc; \
CALL_MCOUNT
Using CALL_MCOUNT in implementation of _mcount isn't going to end well.
I guess I could '#undef PROF', but that seems fragile and likely to
cause further problems.
--
Paul Pluzhnikov