This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix readdir_r with long file names

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>, "Michael Kerrisk (man-pages)" <mtk dot manpages at gmail dot com>, Siddhesh Poyarekar <siddhesh at redhat dot com>
Cc: Rich Felker <dalias at aerifal dot cx>, Carlos O'Donell <carlos at redhat dot com>, KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>, libc-alpha <libc-alpha at sourceware dot org>, Roland McGrath <roland at hack dot frob dot com>, linux-man <linux-man at vger dot kernel dot org>
Date: Tue, 1 Mar 2016 13:20:59 -0800
Subject: Re: [PATCH] Fix readdir_r with long file names
Authentication-results: sourceware.org; auth=none
References: <51B0B39F dot 4060202 at redhat dot com> <51B0BD36 dot 3030202 at redhat dot com> <CAHGf_=r9Rz63pho+84ORk0a_oDyJSj-MCnZ56uPrT3L6sVEfeQ at mail dot gmail dot com> <20130607013024 dot GO29800 at brightrain dot aerifal dot cx> <51B19203 dot 3070307 at redhat dot com> <20130607144143 dot GQ29800 at brightrain dot aerifal dot cx> <51B57E35 dot 4080403 at redhat dot com> <51B65EA7 dot 2020402 at redhat dot com> <20130611011324 dot GT29800 at brightrain dot aerifal dot cx> <51B8702D dot 2060505 at redhat dot com> <20130813040038 dot GE21795 at spoyarek dot pnq dot redhat dot com> <520C88A6 dot 9070501 at redhat dot com> <56D54DAD dot 1040306 at gmail dot com> <56D5CA79 dot 9030204 at redhat dot com> <56D5F832 dot 3070209 at gmail dot com> <56D5FB3D dot 5000306 at redhat dot com>

On 03/01/2016 12:27 PM, Florian Weimer wrote:

We
should implement compiler support for this wart: inhibit optimizations
(I think there are already special cases for length-0 and length-1
arrays at the end, so it's not totally without precedent), and warn
about sizeof (struct dirent) and using it as a (non-pointer) declarator.

Why not use a flexible array member for this? Sure, that assumes C99,but flexible array members are pretty much universally supported now(and we can fall back on the current layout for pre-C99 compilers). Thiswould work better with modern compilers that treat small arrays withmore respect than traditional C compilers did. And as I understandthings, it would conform to POSIX (and if I'm wrong, POSIX should getfixed....).

For what it's worth, portable code cannot copy struct dirent valuesanyway, as this loses file names in operating systems like Solaris whered_name has size 1.

Follow-Ups:
- Re: [PATCH] Fix readdir_r with long file names
  - From: Florian Weimer

References:
- Re: [PATCH] Fix readdir_r with long file names
  - From: Michael Kerrisk (man-pages)
- Re: [PATCH] Fix readdir_r with long file names
  - From: Florian Weimer
- Re: [PATCH] Fix readdir_r with long file names
  - From: Michael Kerrisk (man-pages)
- Re: [PATCH] Fix readdir_r with long file names
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]