This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/5] Consolidate off_t/off64_t syscall argument passing

From: Mike Frysinger <vapier at gentoo dot org>
To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
Cc: libc-alpha at sourceware dot org, Adhemerval Zanella <adhemerval dot zanella at linaro dot com>
Date: Thu, 25 Feb 2016 06:39:19 +0900
Subject: Re: [PATCH 3/5] Consolidate off_t/off64_t syscall argument passing
Authentication-results: sourceware.org; auth=none
References: <1456346889-9862-1-git-send-email-adhemerval dot zanella at linaro dot org> <1456346889-9862-4-git-send-email-adhemerval dot zanella at linaro dot org>

On 24 Feb 2016 17:48, Adhemerval Zanella wrote:
> +#define SYSCALL_LL(__val)   \
> +  __LONG_LONG_PAIR (__val >> 31, __val)
> +#define SYSCALL_LL64(__val) \
> +  __LONG_LONG_PAIR ((long) (__val >> 32), (long) (__val & 0xffffffff))

shouldn't __val be parenthesized ?

#define SYSCALL_LL(__val) __LONG_LONG_PAIR ((__val) >> 31, (__val))

also, does this really need to be __val ?  it's a macro so it's not
like someone using a var or define named __val would affect this.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH 0/5] Cancellation entrypoint refactor
  - From: Adhemerval Zanella
- [PATCH 3/5] Consolidate off_t/off64_t syscall argument passing
  - From: Adhemerval Zanella

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]