Re: [PATCH] intl: reintroduce unintentionally disabled optimization

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Mon, Feb 22, 2016 at 01:31:50PM +0100, Florian Weimer wrote:
> * Andreas Schwab:
> > Dmitry V. Levin writes:
> >
> >> HAVE_BUILTIN_EXPECT macro was removed by commit glibc-2.14-280-g3ce1f29,
> >> but then unintentionally reintroduced during merge with GNU gettext
> >> 0.19.3 by commit glibc-2.20-324-g6d24885, effectively disabling all
> >> optimization based on __builtin_expect.  As intl files are also part
> >> of GNU gettext, HAVE_BUILTIN_EXPECT macro cannot be removed, so guard
> >> its use with _LIBC macro.
> >
> > How about defining HAVE_BUILTIN_EXPECT in config.h.in?
> 
> Is config.h.in regenerated by autoreconf and similar tools?

No, it's supported manually and therefore permanently out of sync.
For example,

$ grep -i strerror config.h.in 
#undef	HAVE_STRERROR
#define	HAVE_STRERROR	1
find -name configure.ac | xargs grep -i strerror | wc -l
0


-- 
ldv

Attachment: pgp4A3DQnbTjO.pgp
Description: PGP signature