This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #19490] Add unwind descriptors to pthread_spin_init, etc. on i386
- From: Torvald Riegel <triegel at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Mon, 25 Jan 2016 14:06:30 +0100
- Subject: Re: [PATCH][BZ #19490] Add unwind descriptors to pthread_spin_init, etc. on i386
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobPJLwc+iSG+w-2YqqiL6=iAL-ZPiS5iKtmdDmJTR9Fp6g at mail dot gmail dot com>
On Sat, 2016-01-23 at 16:18 -0800, Paul Pluzhnikov wrote:
> 2016-01-23 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> [BZ #19490]
> * sysdeps/i386/i386-mcount.S (_mcount): Add unwind descriptor
> (__fentry__): Likewise
> * sysdeps/unix/sysv/linux/i386/_exit.S (_exit): Use ENTRY/END
> * sysdeps/i386/nptl/pthread_spin_lock.S (pthread_spin_lock):
> Likewise
> * sysdeps/i386/pthread_spin_trylock.S (pthread_spin_trylock):
> Likewise
> * sysdeps/i386/nptl/pthread_spin_unlock.S (pthread_spin_unlock):
> Likewise
For the spinlocks, I'd really prefer if we could just remove the asm
files. The generic implementation should basically produce the same
code; if not, we should try to fix that instead of keeping the asm
files.