This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add framework for tunables
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <sid at reserved-bit dot com>
- Cc: <libc-alpha at sourceware dot org>, <roland at hack dot frob dot com>, <carlos at redhat dot com>, "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, Andi Kleen <andi at firstfloor dot org>
- Date: Mon, 11 Jan 2016 19:02:46 +0000
- Subject: Re: [PATCH 1/2] Add framework for tunables
- Authentication-results: sourceware.org; auth=none
- References: <20160111111649 dot GA4157 at devel dot intra dot reserved-bit dot com>
On Mon, 11 Jan 2016, Siddhesh Poyarekar wrote:
> +# * False positive: tunable_register, compat_tunables_init_envvars,
> +# tunables_init. These functions are in the glibc internal namespace.
> @whitelist = qw(stdin stdout stderr re_syntax_options matherr matherrf
> - matherrl);
> + matherrl tunable_register compat_tunables_init_envvars tunables_init);
I don't understand this comment. None of those names are in an internal
namespace. All those functions should be renamed to start with __.
--
Joseph S. Myers
joseph@codesourcery.com