This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add pretty printers for the NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: Martin Galvan <martin dot galvan at tallertechnologies dot com>, libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, "Carlos O'Donell" <carlos at redhat dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Fri, 8 Jan 2016 10:31:51 -0300
- Subject: Re: [PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <CAOKbPbbVud=gru917mXYfnOnQ9nCCY1vR4fvyU8JpRVzaGe5bw at mail dot gmail dot com> <1446939548-30602-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160108082325 dot GJ25548 at vapier dot lan>
On Fri, Jan 8, 2016 at 5:23 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On 07 Nov 2015 20:39, Martin Galvan wrote:
>> --- /dev/null
>> +++ b/nptl/nptl-printers.py
>> +import sys
>
> as the linter points out, this is unused, so you should drop it
>
> can you post a v4 with all the comments fixed ?
>
>> +MUTEX_TYPES = {
>> + PTHREAD_MUTEX_NORMAL: ('Type', 'Normal'),
>> + PTHREAD_MUTEX_RECURSIVE: ('Type', 'Recursive'),
>> + PTHREAD_MUTEX_ERRORCHECK: ('Type', 'Error check'),
>> + PTHREAD_MUTEX_ADAPTIVE_NP: ('Type', 'Adaptive')
>> +}
>
> imo, we should have dangling commas with lists/dicts/tuples like we do
> in C with arrays.
> -mike
Thanks for the reply. Most of the answers on this are in this thread:
https://sourceware.org/ml/libc-alpha/2015-11/msg00257.html
Right now this is on a bit of a hiatus because other glibc maintainers
requested for unit tests for this. I'm working on them using DejaGNU,
but I don't know when they will be finished. I'll send in a v4 when
it's done.