This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Test various special cases related to allocation failures
- From: Florian Weimer <fweimer at redhat dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 29 Dec 2015 20:35:28 +0100
- Subject: Re: [PATCH] malloc: Test various special cases related to allocation failures
- Authentication-results: sourceware.org; auth=none
- References: <568190BA dot 30308 at redhat dot com> <20151229171921 dot GB26641 at altlinux dot org>
On 12/29/2015 06:19 PM, Dmitry V. Levin wrote:
> On Mon, Dec 28, 2015 at 08:42:50PM +0100, Florian Weimer wrote:
>> This test case exercises unusual code paths in allocation functions,
>> related to allocation failures.
>
> LGTM.
Thanks.
>
> [...]
>> + if (page_size != 4096)
>> + {
>> + allocation_size = page_size;
>> + run_allocation_functions ();
>> + }
>
> Why this test is not needed for page_size == 4096?
> It might worth a comment.
Ugh, I had trimmed the tests incorrectly. I fixed that before committing.
Florian