This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Enable demuxed sysv IPC syscalls

On Wed, 2015-12-16 at 10:59 +0100, Andreas Schwab wrote:
> Michael Ellerman <> writes:

> > So the only complication with reverting the patch is that we've since added
> > sys_mlock2 after the IPC calls, as NR 378.
> > 
> > I guess because we haven't released a kernel with mlock2 using that number I'll
> > just renumber it, as if the IPC calls were never there.
> There is no need to renumber, a gap doesn't pose any difficulties.
> Syscall numbers can be reserved any time, the important part is that you
> get ENOSYS when trying to call the new ipc syscalls until the final ABI
> is implemented.


I think it's also important not to #define __NR_semop etc. right? Otherwise
userspace code might be doing #ifdef __NR_semop to detect whether that syscall
is implemented.

So the kernel revert patch becomes:

diff --git a/arch/powerpc/include/asm/systbl.h b/arch/powerpc/include/asm/systbl.h
index f2b0b1b0c72a..5654ece02c0d 100644
--- a/arch/powerpc/include/asm/systbl.h
+++ b/arch/powerpc/include/asm/systbl.h
@@ -370,16 +370,16 @@ COMPAT_SYS(execveat)
diff --git a/arch/powerpc/include/uapi/asm/unistd.h b/arch/powerpc/include/uapi/asm/unistd.h
index 1effea5193d6..12a05652377a 100644
--- a/arch/powerpc/include/uapi/asm/unistd.h
+++ b/arch/powerpc/include/uapi/asm/unistd.h
@@ -388,18 +388,6 @@
 #define __NR_switch_endian	363
 #define __NR_userfaultfd	364
 #define __NR_membarrier		365
-#define __NR_semop		366
-#define __NR_semget		367
-#define __NR_semctl		368
-#define __NR_semtimedop		369
-#define __NR_msgsnd		370
-#define __NR_msgrcv		371
-#define __NR_msgget		372
-#define __NR_msgctl		373
-#define __NR_shmat		374
-#define __NR_shmdt		375
-#define __NR_shmget		376
-#define __NR_shmctl		377
 #define __NR_mlock2		378

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]