This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] grantpt: trust the kernel about pty group and permission mode
- From: Florian Weimer <fweimer at redhat dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>, libc-alpha at sourceware dot org
- Cc: Jakub Wilk <jwilk at debian dot org>, Adam Conrad <adconrad at 0c3 dot net>
- Date: Sun, 6 Dec 2015 21:28:09 +0100
- Subject: Re: [PATCH] grantpt: trust the kernel about pty group and permission mode
- Authentication-results: sourceware.org; auth=none
- References: <1449414023-28926-1-git-send-email-aurelien at aurel32 dot net>
On 12/06/2015 04:00 PM, Aurelien Jarno wrote:
> +2015-12-06 Aurelien Jarno <aurelien@aurel32.net>
> + Jakub Wilk <jwilk@debian.org>
> +
> + * sysdeps/unix/grantpt.c (grantpt): Do not try to change the group
> + of the device to the tty group when built without pt_chown support.
Thanks for posting this. It looks good to me. I have tried it with a
default-settings devpts, and screen works (when it would fail before).
Can you file a bug and reference it in the commit and ChangeLog, for
tracking purposes? I don't think a separate NEWS entry is needed, but
the bug might be helpful in the future.
Florian