This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: More elision improvements
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: "libc-alpha\ at sourceware dot org" <libc-alpha at sourceware dot org>, Torvald Riegel <triegel at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc:
- Date: Thu, 19 Nov 2015 17:40:36 -0200
- Subject: Re: [PATCH] powerpc: More elision improvements
- Authentication-results: sourceware.org; auth=none
- References: <56314D77 dot 5080703 at linux dot vnet dot ibm dot com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> __lll_trylock_elision sets the adapt_count variable too
> aggressively, and incorrectly on persistent aborts. Taking
> a cue from s390, adapt_count is only updated if the lock
> is locked, or a persistent failure occurs.
>
> In addition, the abort codes have been renumbered and
> refactored for clarity. As it stands, glibc only cares
> if the abort is persistent or not.
>
> All aborts are now persistent, excepting a busy lock. This
> includes changing _ABORT_NESTED_TRYLOCK into a persistent
> abort.
>
> 2015-10-28 Paul E. Murphy <murphyp@linux.vnet.ibm.com>
>
> * sysdeps/unix/sysv/linux/powerpc/elision-trylock.c
> (__lll_trylock_elision): Fix setting of adapt_count.
> * sysdeps/unix/sysv/linux/powerpc/htm.h
> (_ABORT_PERSISTENT): Define to clarify persistent aborts.
> (_ABORT_NESTED_TRYLOCK): Renumber, and make persistent.
> (_ABORT_SYSCALL): Renumber, and clarify definition.
> (_ABORT_LOCK_BUSY): Renumber, make non-persistent.
LGTM too.
Pushed as 86b49398.
--
Tulio Magno