This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org, "Carlos O'Donell" <carlos at redhat dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Tue, 17 Nov 2015 16:14:15 -0300
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <564B4DE4 dot 7010306 at redhat dot com> <CAOKbPbYus7ci-zY0PMCFQ6rx1a3LUv=N=aJBXYV1bsWXwLGXzA at mail dot gmail dot com> <87h9kk8r8o dot fsf at tromey dot com>
On Tue, Nov 17, 2015 at 2:34 PM, Tom Tromey <tom@tromey.com> wrote:
> With a correct setup (typically done by the distros), you shouldn't need
> this.
Curious, at least Ubuntu 14.04 doesn't seem to do this.
Anyway, I'd like this patch to be reviewed first so we can make sure
there are no (obvious) flaws. Mike Frysinger and Joseph Myers already
pointed out some things which I fixed for this version. Is there a
chance to merge just this code and later the unit tests, or must it
all go in as one big commit?