This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Make bits/math-finite.h conditions match other headers (bug 19205) [committed]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 9 Nov 2015 16:36:58 +0100
- Subject: Re: Make bits/math-finite.h conditions match other headers (bug 19205) [committed]
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1511050049220 dot 18787 at digraph dot polyomino dot org dot uk>
On 11/05/2015 01:49 AM, Joseph Myers wrote:
> bits/math-finite.h declares -ffinite-math-only variants of various
> functions under conditions not matching those under which the normal
> versions are declared.
Joseph,
I may be seeing build failures related to this change, on armhfp (which
is, I think, ARMv7 with hardware floating point). Specifically, this:
In file included from ../include/sys/cdefs.h:3:0,
from ../include/features.h:368,
from ../math/math.h:26,
from ../include/math.h:3,
from test-signgam-finite-c99.c:23:
./bits/math-finite.h:29:36: error: conflicting types for 'acosl'
extern long double __REDIRECT_NTH (acosl, (long double), __acos_finite);
^
../misc/sys/cdefs.h:185:6: note: in definition of macro '__REDIRECT_NTH'
name proto __asm__ (__ASMNAME (#alias)) __THROW
^
In file included from ../include/math.h:3:0,
from test-signgam-finite-c99.c:23:
../math/bits/mathcalls.h:54:13: note: previous declaration of 'acosl'
was here
__MATHCALL (acos,, (_Mdouble_ __x));
^
../math/math.h:146:35: note: in definition of macro '__MATH_PRECNAME'
# define __MATH_PRECNAME(name,r) name##l##r
^
../math/math.h:68:3: note: in expansion of macro '__MATHDECL_1'
__MATHDECL_1(type, function,suffix, args); \
^
../math/math.h:66:3: note: in expansion of macro '__MATHDECL'
__MATHDECL (_Mdouble_,function,suffix, args)
^
../math/bits/mathcalls.h:54:1: note: in expansion of macro '__MATHCALL'
__MATHCALL (acos,, (_Mdouble_ __x));
^
Full build log is here:
<https://kojipkgs.fedoraproject.org//work/tasks/5405/11755405/build.log>
If this doesn't ring any immediate bells, we'll figure it out on our
own, no worries.
Florian