This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Implement "make update-all-abi"
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 5 Nov 2015 13:39:58 -0800 (PST)
- Subject: Re: [PATCH] Implement "make update-all-abi"
- Authentication-results: sourceware.org; auth=none
- References: <56326011 dot 4030506 at redhat dot com>
> +define update-all-abi
> +bash $(..)scripts/update-abilist.sh $^ \
$(BASH)
But what in this script is actually using a bash extension? If it doesn't
take much effort to keep a script POSIX sh-compatible, we should do it.
> + $$(find $(..)sysdeps \
> + -regextype posix-egrep -regex '.*/$*([^a-z0-9].*)?\.abilist$$' \
> + \! -regex '.*/generic/.*')
> +endef
Why isn't this find just rolled into the script?
> +if test $# -lt 3 ; then
Use [ ... ] rather than test. No space before a ; like that.
> + echo "usage: $0 OLD-FILE NEW-FILE FILES-TO-BE-PATCHED..." 1>&2
Two-space indent.
> + if ! cmp -s -- "$to_be_patched" "$tmp_patched" ; then
> + echo "info: updating $to_be_patched" 1>&2
> + cp -- "$tmp_patched" "$to_be_patched"
> + fi
Just call out to move-if-change for this.