This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/25] _dl_fini: Rewrite to use VLA instead of extend_alloca
- From: Florian Weimer <fweimer at redhat dot com>
- To: libc-alpha at sourceware dot org
- Cc: carlos at redhat dot com
- Date: Thu, 29 Oct 2015 10:04:24 +0100
- Subject: Re: [PATCH 01/25] _dl_fini: Rewrite to use VLA instead of extend_alloca
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1425285061 dot git dot fweimer at redhat dot com> <4640427f7b0c3de94ac8792a85a7d3c5ef2d5084 dot 1425285061 dot git dot fweimer at redhat dot com> <56305909 dot 4000208 at redhat dot com>
On 10/28/2015 06:11 AM, Carlos O'Donell wrote:
> On 03/01/2015 08:49 AM, Florian Weimer wrote:
>> In this case, extend_alloca is used to work around the lack of
>> deallocation on scope exit. A VLA is automatically deallocated in this
>> way, so it is the more fitting approach.
>>
>> To implement this, it is necessary to eliminate the goto. In addition,
>> this change eliminates the trivially-true assert; the assert is always
>> skipped if nloaded > 0.
>
> This looks good to me.
>
> It's a good use of VLA.
>
> Please check this in.
Thanks, committed
> Make sure you follow GNU Changelog format (you didn't post one for review).
The ChangeLog was posted in 00/25:
<https://sourceware.org/ml/libc-alpha/2015-03/msg00056.html>
Florian