This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]

From: Mike Frysinger <vapier at gentoo dot org>
To: Florian Weimer <fweimer at redhat dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>, Hannes Sowa <hannes at redhat dot com>, netdev at vger dot kernel dot org
Date: Sat, 24 Oct 2015 00:22:03 -0400
Subject: Re: [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]
Authentication-results: sourceware.org; auth=none
References: <562A9391 dot 1040806 at redhat dot com>

On 23 Oct 2015 22:07, Florian Weimer wrote:
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/netlink_assert_response.c
> @@ -0,0 +1,100 @@
> +/* Copyright (C) 2015 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.

guess we like to have the first line be a short desc of the file

> +static int
> +get_address_family (int fd)
> +{
> ...
> +  return sa.ss_family;

ss_family is of type sa_family_t, not int ... not a big deal, but the
two do differ in sign ...
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]
  - From: Hannes Frederic Sowa

References:
- [PATCH] glibc: Terminate process on invalid netlink response from kernel [BZ #12926]
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]