This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedef: Add --localedir and --archive-file options (Bug 19130)
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Mike Frysinger <vapier at gentoo dot org>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 22 Oct 2015 10:29:27 -0400
- Subject: Re: [PATCH] localedef: Add --localedir and --archive-file options (Bug 19130)
- Authentication-results: sourceware.org; auth=none
- References: <561F230E dot 5050801 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1510151147210 dot 9529 at digraph dot polyomino dot org dot uk> <56257C9D dot 8090200 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1510192344450 dot 3569 at digraph dot polyomino dot org dot uk> <562641A2 dot 8090906 at redhat dot com> <mvm1tcppmby dot fsf at hawking dot suse dot de> <5627B868 dot 2050402 at redhat dot com> <mvmwpufmj3b dot fsf at hawking dot suse dot de> <5628EB39 dot 3020805 at redhat dot com> <mvmio5zkn4g dot fsf at hawking dot suse dot de>
On 10/22/2015 10:13 AM, Andreas Schwab wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>
>> On 10/22/2015 03:57 AM, Andreas Schwab wrote:
>>> "Carlos O'Donell" <carlos@redhat.com> writes:
>>>
>>>> diff --git a/Makeconfig b/Makeconfig
>>>> index 1dc522c..4e585ce 100644
>>>> --- a/Makeconfig
>>>> +++ b/Makeconfig
>>>> @@ -190,11 +190,11 @@ zonedir = $(datadir)/zoneinfo
>>>> endif
>>>> inst_zonedir = $(install_root)$(zonedir)
>>>>
>>>> -# Where to install the locale files.
>>>> -ifndef localedir
>>>> -localedir = $(libdir)/locale
>>>> +# Where to install the binary locale archive and binary locale files.
>>>> +ifndef locale_archive_dir
>>>
>>> Why "archive"? It doesn't store only the archive.
>>
>> How about:
>>
>> $(locbindir)
>
> Please don't abbreviate locale. Otherwise ok with me.
OK. Final form is:
$(localebindir)
LOCALEBINDIR
I'll post the patch after testing.
c.