This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies

From: Mike Frysinger <vapier at gentoo dot org>
To: Andreas Schwab <schwab at suse dot de>
Cc: Florian Weimer <fweimer at redhat dot com>, Martin Sebor <msebor at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 16 Oct 2015 23:16:01 -0400
Subject: Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
Authentication-results: sourceware.org; auth=none
References: <560471F5 dot 9080800 at gmail dot com> <mvmh9lwzaxk dot fsf at hawking dot suse dot de> <561B92D6 dot 4010402 at redhat dot com> <20151012164344 dot GB4446 at vapier dot lan> <mvmziznxmsi dot fsf at hawking dot suse dot de>

On 13 Oct 2015 09:14, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> > pretty sure that's not a problem.  $(gen-locales) expands into:
> > CTYPE_FILES = $(addsuffix /LC_CTYPE,$(LOCALES))
> > gen-locales := $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES))
> >
> > so it creates one dep per locale.
> 
> Each subdir has its independent set of dependencies.
> 
> > $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES)): %: \
> >   ../localedata/gen-locale.sh \
> >   $(common-objpfx)locale/localedef \
> >   ../localedata/Makefile \
> >   $(addprefix ../localedata/charmaps/,$(CHARMAPS)) \
> >   $(addprefix ../localedata/locales/,$(LOCALE_SRCS))
> >     @$(SHELL) ../localedata/gen-locale.sh $(common-objpfx) \
> >           '$(built-program-cmd-before-env)' '$(run-program-env)' \
> >           '$(built-program-cmd-after-env)' $@; \
> >     $(evaluate-test)
> >
> > so it generates one locale per invocation.  it looks correct to me.
> 
> Different subdirs can build the same locale in parallel.

to be clear, i didn't say otherwise, and i'm aware of this behavior.
i was pointing out that each subdir builds each required locale in
parallel and does so with proper targets.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
  - From: Andreas Schwab

References:
- Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
  - From: Andreas Schwab
- Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
  - From: Florian Weimer
- Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
  - From: Mike Frysinger
- Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]