This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Do not leave files behind in /tmp from testing
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 15 Oct 2015 15:22:47 -0700 (PDT)
- Subject: Re: Do not leave files behind in /tmp from testing
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1510152049430 dot 6002 at digraph dot polyomino dot org dot uk> <20151015211437 dot 0A13E2C3C14 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1510152117510 dot 6002 at digraph dot polyomino dot org dot uk> <20151015213704 dot C64FF2C3C14 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1510152148060 dot 6002 at digraph dot polyomino dot org dot uk> <20151015220312 dot 33E0B2C3C0C at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1510152207450 dot 6002 at digraph dot polyomino dot org dot uk>
> I still don't see what this has to do with my patch. It may be a case for
> a general review of where tests create and register temporary files to be
> entered on the wiki todo list. But the add_temp_file call that my patch
> moves could never have done anything useful before (because it registered
> the wrong name) - so I don't see how my patch could regress anything that
> worked before (and in the case of normal termination, my patch should fix
> things whether or not TEST_DIRECT applies).
Your patch purports to be a cleanup, but for this case it changes things in
the wrong direction.
Since there is no controversy about the other changes in your patch,
perhaps you should commit those separately so they are not conflated
with the more complex issues raised by this one change.