This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][ARM] Fix _dl_tlsdesc_resolve_hold to save r0
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 14 Oct 2015 12:17:17 +0000
- Subject: Re: [PATCH][ARM] Fix _dl_tlsdesc_resolve_hold to save r0
- Authentication-results: sourceware.org; auth=none
- References: <561E1E63 dot 3020404 at arm dot com>
On Wed, 14 Oct 2015, Szabolcs Nagy wrote:
> _dl_tlsdesc_resolve_hold calls into a C function that clobbers r0,
> but it assumes the original argument is still in r0 after the call.
> This can cause crash in case of concurrent TLS access when TLSDESC
> is in use (-mtls-dialect=gnu2).
I presume this issue was user-visible in a release, in which case a bug
should be filed in Bugzilla for it. Should I take it that it's hard to
write a testcase for this bug that fails reliably without the patch?
--
Joseph S. Myers
joseph@codesourcery.com