This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Paul Pluzhnikov <ppluzhnikov at gmail dot com>, GLIBC Devel <libc-alpha at sourceware dot org>, Paul Pluzhnikov <ppluzhnikov at google dot com>
Date: Sat, 3 Oct 2015 11:41:24 -0700
Subject: Re: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open
Authentication-results: sourceware.org; auth=none
References: <CAPC3xarLZpvmAwhyVj-v6C65QkepJMhSJGfZ2ZYQATXesm94fw at mail dot gmail dot com> <20150928173140 dot GA5374 at vapier dot lan>

On Mon, Sep 28, 2015 at 10:31 AM, Mike Frysinger <vapier@gentoo.org> wrote:

> what about the other failure case (init_fct returns an error) ?

Good point.

> the strduping seems a bit convoluted and makes error handling error prone.
> what about something a bit more straightforward:

May as well also add a check for strdup failure. Updated patch attached.

Thanks,

2015-10-03  Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ #19012]
        * iconv/gconv_db.c (gen_steps): Check for additional errors.
Clean up on failure.

-- 
Paul Pluzhnikov

Attachment: glibc-bz19012-20151003.txt
Description: Text document

Follow-Ups:
- Re: [patch] Fix BZ 19012 -- memory leak on error path in iconv_open
  - From: Mike Frysinger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]