This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Harden put*ent functions against data injection [BZ #18724]
- From: Florian Weimer <fweimer at redhat dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 2 Oct 2015 13:26:46 +0200
- Subject: Re: [PATCH] Harden put*ent functions against data injection [BZ #18724]
- Authentication-results: sourceware.org; auth=none
- References: <55B64BE2 dot 9060905 at redhat dot com> <55B68DBE dot 2050009 at redhat dot com> <560E5096 dot 3040306 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1510021114380 dot 31564 at digraph dot polyomino dot org dot uk>
On 10/02/2015 01:15 PM, Joseph Myers wrote:
> i386 build fixed thus. Committed.
>
> Fix i386 build after put*ent hardening changes.
>
> The recent put*ent hardening changes broke the build for i386. i386
> defines internal_function to __attribute__ ((regparm (3), stdcall)),
> which affects type compatibility, so requiring internal_function to be
> used consistently on declarations and definitions. This patch adds
> internal_function to the definitions of the new functions using it on
> their declarations.
Ugh, thanks. I've asked on gcc-help if there is some attribute we can
use to catch this on other architectures as well.
I guess I need to set up things to build everything on i386, too, if GCC
continues to behave this way.
Florian