This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix BZ 18985 out of bounds access in strftime

From: Mike Frysinger <vapier at gentoo dot org>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: Paul Eggert <eggert at cs dot ucla dot edu>, GLIBC Devel <libc-alpha at sourceware dot org>
Date: Sun, 20 Sep 2015 21:23:57 -0400
Subject: Re: [patch] Fix BZ 18985 out of bounds access in strftime
Authentication-results: sourceware.org; auth=none
References: <CAPC3xao-5YF_icBWE5yYbaYiUmiAvmb7w9s_G-dqawsx7eoTkQ at mail dot gmail dot com> <55FE5473 dot 7030305 at cs dot ucla dot edu> <CALoOobOWfPWuwtw_XgcTKx2yn=p3YbB04_B965zKRCkC1qsPjQ at mail dot gmail dot com> <55FEFD47 dot 4090401 at cs dot ucla dot edu> <CALoOobMOFtQVcCK4bR3VpeLMoj4bXVa12GAk0CjP6MMxuQU+Fw at mail dot gmail dot com> <20150920231004 dot GC7802 at vapier dot lan> <CALoOobNP2wrjtOMUBkpfuA7aKKpP3pWya9Euxg=darKmRS17MA at mail dot gmail dot com>

On 20 Sep 2015 16:16, Paul Pluzhnikov wrote:
> On Sun, Sep 20, 2015 at 4:10 PM, Mike Frysinger wrote:
> > buf = INVALID<H/tm_hour=1024> 1012
> 
> It's fairly trivial to modify my patch to show "INVALID tm_wday" instead of "?".

using a const string is fine.  better than just "?" imo.

> Doing that for tm_hour is just a bit more involved, though not that
> much. But it seems that that would be something Paul E. *doesn't* want
> in his "IST-2IDT,M3.4.4/26,M10.5.0" example.

i'm not sure that's readily obvious that there's a failure.  seems like it's
easy to pass on to other layers which also might not notice until it's much
too late.
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Eggert
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Eggert
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Mike Frysinger
- Re: [patch] Fix BZ 18985 out of bounds access in strftime
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]