This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix memory leak in printf_positional
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: Carlos O'Donell <carlos at redhat dot com>, Paul Eggert <eggert at cs dot ucla dot edu>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Thu, 3 Sep 2015 11:24:41 +0000
- Subject: Re: [PATCH] Fix memory leak in printf_positional
- Authentication-results: sourceware.org; auth=none
- References: <1440571295-20230-1-git-send-email-eggert at cs dot ucla dot edu> <alpine dot DEB dot 2 dot 10 dot 1508260930500 dot 26898 at digraph dot polyomino dot org dot uk> <55DFB7C7 dot 50307 at redhat dot com> <alpine dot DEB dot 2 dot 10 dot 1508281350520 dot 5939 at digraph dot polyomino dot org dot uk> <55E06924 dot 2000209 at redhat dot com> <CALoOobMkGafD9zvq9g13TM8_Nd+HmC58_8gMGTQhdefXpko3CA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1508311039110 dot 27932 at digraph dot polyomino dot org dot uk> <CALoOobO2iV9hPNB_S7PDoL=cWVCPrSkKGaUQfqboxUg40fsrVw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1509021004030 dot 3590 at digraph dot polyomino dot org dot uk> <CALoOobN6LcGFEkieN3CJQ7mKeL7m5H3_aaYb17uEW9ZE_zX4yA at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1509021427530 dot 27392 at digraph dot polyomino dot org dot uk> <55E73436 dot 1050305 at redhat dot com> <CALoOobMusa6usQCEAR2bs8ES2EbHRa9YuCARd9=ewq1eROPLmQ at mail dot gmail dot com>
On Wed, 2 Sep 2015, Paul Pluzhnikov wrote:
> On Wed, Sep 2, 2015 at 10:39 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>
> >>> I think at that point it becomes easier to just use a generator script
> >>> to write the test. Any objection to that?
> >>
> >> I don't object to that given an appropriate comment on why it is being
> >> used.
> >
> > Agreed.
>
> What's the appropriate place to put this comment?
I'd suggest in the Makefile.
> +# Copyright (C) 1999-2015 Free Software Foundation, Inc.
This is a new test; I'd expect just 2015 unless closely based on an
existing test.
--
Joseph S. Myers
joseph@codesourcery.com