This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/8] Move i486/pthread_spin_trylock.S to pthread_spin_trylock.S


On Wed, 2015-08-26 at 12:33 -0700, H.J. Lu wrote:
> On Wed, Aug 26, 2015 at 11:02 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> > On Wed, 26 Aug 2015, H.J. Lu wrote:
> >
> >> Since glibc doesn't support i386 any more, we can move
> >> i486/pthread_spin_trylock.S to pthread_spin_trylock.S
> >
> > The i686 version wasn't just a #include - you're losing the HAVE_CMOV
> > define in this patch.
> >
> > This illustrates the use of testing these patches by making sure that
> > stripped installed shared libraries (for each of i486, i586 and i686) are
> > identical before and after the patch series.
> >
> 
> Here is the updated patch.  There are no changes in generated
> shared libraries for i486, i586 amd i686 targets.
> 
> OK for master?
> 

Could you instead please try to replace the custom asm implementation
with a C implementation, preferably the generic one in
nptl/pthread_spin_trylock.c?  And, if necessary, and improve the latter
if there is a significant performance difference for uncontended locks?

Thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]