Re: [PATCHv3] PowerPC: Fix a race condition when eliding a lock

["Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>]

Torvald Riegel <triegel@redhat.com> writes:

> On Mon, 2015-08-24 at 16:19 -0300, Tulio Magno Quites Machado Filho
> wrote:
>> "Carlos O'Donell" <carlos@redhat.com> writes:
>> 
>> > On 08/24/2015 02:11 PM, Tulio Magno Quites Machado Filho wrote:
>> >> Changes since v2:
>> >>  - Moved part of the source code comments to the commit message.
>> >>  - Added O'Donnel's suggestion to the source code comments.
>> >> 
>> >> Changes since v1:
>> >>  - Improved commit message.
>> >>  - Added new comments in the source code alerting to the concurrency details
>> >>    intrinsic to this code.
>> >>  - Removed compiler barriers from this patch, which will be treated in another
>> >>    patch and will be synchronized with the GCC implementation.
>> >
>> Reason #2 is a valid point, but is unrelated to this patch, i.e. I wouldn't
>> backport the atomic access to glibc 2.21 and 2.22 if the only reason for it
>> is #2.  So, it would be better as a separate patch.
>
> I wouldn't object if you split this into two parts, and only backport
> those patches that are necessary for correctness.

Great!  So, let's split this discussion in 2: one to review the patch for bug
#18743 and another which is an RFC to create a rule to consistently use atomic
access to a memory object that need at least one atomic access.

Both discussions are completely unrelated, except that the former started the
latter.

-- 
Tulio Magno