This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv4] Call direct system calls for socket operations
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: schwab at suse dot de
- Cc: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org, Steven Munroe <munroesj at linux dot vnet dot ibm dot com>
- Cc:
- Date: Mon, 24 Aug 2015 15:46:20 -0300
- Subject: Re: [PATCHv4] Call direct system calls for socket operations
- Authentication-results: sourceware.org; auth=none
- References: <1435830813-4282-1-git-send-email-raji at linux dot vnet dot ibm dot com> <1439532720-4720-1-git-send-email-raji at linux dot vnet dot ibm dot com> <1439923910 dot 569 dot 0 dot camel at oc7878010663>
Steven Munroe <munroesj@linux.vnet.ibm.com> writes:
> On Fri, 2015-08-14 at 11:42 +0530, Rajalakshmi Srinivasaraghavan wrote:
>> Explicit system calls for the socket operations were added in Linux kernel
>> in commit 86250b9d12ca for powerpc. This patch make use of those instead of
>> calling socketcall to save number of cycles on networking syscalls.
>>
>> 2015-08-14 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
>>
>> * sysdeps/unix/sysv/linux/powerpc/kernel-features.h: Define new macros.
>> * sysdeps/unix/sysv/linux/accept.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/bind.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/connect.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/getpeername.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/getsockname.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/getsockopt.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/listen.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/recv.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/recvfrom.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/recvmsg.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/send.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/sendmsg.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/sendto.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/setsockopt.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/shutdown.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/socket.c: Call direct system call.
>> * sysdeps/unix/sysv/linux/socketpair.c: Call direct system call.
>> ---
>
> LGTM
I see we have a green flag for this patch on POWER.
Andreas, any other comments?
--
Tulio Magno