This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use -Wno-uninitialized in math/
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 21 Aug 2015 09:04:39 -0700
- Subject: Re: Don't use -Wno-uninitialized in math/
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1508201800380 dot 30940 at digraph dot polyomino dot org dot uk>
- Reply-to: <sellcey at imgtec dot com>
On Thu, 2015-08-20 at 18:00 +0000, Joseph Myers wrote:
> The uninitialized variable warnings in math/ having been fixed for all
> the supported floating-point formats, this patch removes the use of
> -Wno-uninitialized there, continuing with the goal of avoiding -Wno-
> options in makefiles as far as possible..
>
> Tested for x86_64 and x86 (full build and testsuite runs), and for
> powerpc and mips64 (verified that glibc builds without errors).
> Committed.
I am seeing a mips32 build failure (using Top-of-tree GCC) with this
change:
In file included from ../soft-fp/soft-fp.h:321:0,
from ../soft-fp/fmatf4.c:30,
from ../sysdeps/mips/ieee754/s_fmal.c:7:
../soft-fp/fmatf4.c: In function ï~@~X__fmalï~@~Y:
../soft-fp/op-common.h:281:10: error: ï~@~XR_eï~@~Y may be used uninitialized in this function [-Werror=maybe-uninitialized]
X##_e++; \
^
../soft-fp/fmatf4.c:40:14: note: ï~@~XR_eï~@~Y was declared here
FP_DECL_Q (R);
^
../soft-fp/op-common.h:38:14: note: in definition of macro ï~@~X_FP_DECLï~@~Y
_FP_I_TYPE X##_e __attribute__ ((unused)) _FP_ZERO_INIT; \
^
../soft-fp/fmatf4.c:40:3: note: in expansion of macro ï~@~XFP_DECL_Qï~@~Y
FP_DECL_Q (R);
I am not sure if a DIAG is needed or if something actually needs to be
initialized.
Steve Ellcey
sellcey@imgtec.com