This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Don't use -Wno-uninitialized in math/
- From: Stan Shebs <stanshebs at google dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Thu, 20 Aug 2015 15:33:44 -0500
- Subject: Re: Don't use -Wno-uninitialized in math/
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1508201800380 dot 30940 at digraph dot polyomino dot org dot uk>
On Thu, Aug 20, 2015 at 1:00 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> The uninitialized variable warnings in math/ having been fixed for all
> the supported floating-point formats, this patch removes the use of
> -Wno-uninitialized there, continuing with the goal of avoiding -Wno-
> options in makefiles as far as possible..
Not sure how you didn't see this, but my fresh build fails with this
(GCC 4.8.4, Ubuntu 14.04, vanilla configure):
gcc ../sysdeps/ieee754/ldbl-96/k_tanl.c -c -std=gnu99 -fgnu89-inline
-fno-stack-protector -O2 -Wall -Werror -Wno-error=undef -Wundef
-Wwrite-strings -fmerge-all-constants -frounding-math -g
-Wstrict-prototypes -U_FORTIFY_SOURCE -D__NO_MATH_INLINES
-D__LIBC_INTERNAL_MATH_INLINES -I../include
-I/usr/local/google/home/stanshebs/base/linux/math
-I/usr/local/google/home/stanshebs/base/linux
-I../sysdeps/unix/sysv/linux/x86_64/64
-I../sysdeps/unix/sysv/linux/x86_64 -I../sysdeps/unix/sysv/linux/x86
-I../sysdeps/unix/sysv/linux/wordsize-64 -I../sysdeps/x86_64/nptl
-I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux
-I../sysdeps/nptl -I../sysdeps/pthread -I../sysdeps/gnu
-I../sysdeps/unix/inet -I../sysdeps/unix/sysv
-I../sysdeps/unix/x86_64 -I../sysdeps/unix -I../sysdeps/posix
-I../sysdeps/x86_64/64 -I../sysdeps/x86_64/fpu/multiarch
-I../sysdeps/x86_64/fpu -I../sysdeps/x86/fpu/include
-I../sysdeps/x86/fpu -I../sysdeps/x86_64/multiarch
-I../sysdeps/x86_64 -I../sysdeps/x86 -I../sysdeps/ieee754/ldbl-96
-I../sysdeps/ieee754/dbl-64/wordsize-64 -I../sysdeps/ieee754/dbl-64
-I../sysdeps/ieee754/flt-32 -I../sysdeps/wordsize-64
-I../sysdeps/ieee754 -I../sysdeps/generic -I.. -I../libio -I.
-D_LIBC_REENTRANT -include
/usr/local/google/home/stanshebs/base/linux/libc-modules.h
-DMODULE_NAME=libm -include ../include/libc-symbols.h -o
/usr/local/google/home/stanshebs/base/linux/math/k_tanl.o -MD -MP -MF
/usr/local/google/home/stanshebs/base/linux/math/k_tanl.o.dt -MT
/usr/local/google/home/stanshebs/base/linux/math/k_tanl.o
../sysdeps/ieee754/ldbl-96/k_tanl.c: In function â__kernel_tanlâ:
../sysdeps/ieee754/ldbl-96/k_tanl.c:139:10: error: âsignâ may be used
uninitialized in this function [-Werror=maybe-uninitialized]
if (sign < 0)
^
cc1: all warnings being treated as errors
Stan