This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC] Add IFUNC support for MIPS (v3)
- From: Faraz Shahbazker <faraz dot shahbazker at imgtec dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, <rdsandiford at googlemail dot com>, Joseph Myers <joseph at codesourcery dot com>
- Date: Mon, 17 Aug 2015 11:07:11 -0700
- Subject: Re: [RFC] Add IFUNC support for MIPS (v3)
- Authentication-results: sourceware.org; auth=none
- References: <DCB1C42372B1674B8F912A294CCB775A71684631 at BADAG02 dot ba dot imgtec dot org> <87k2tdn5xt dot fsf at googlemail dot com> <55BFC10F dot 2050503 at imgtec dot com> <87k2tapwq0 dot fsf at googlemail dot com> <55CE5217 dot 5020902 at imgtec dot com> <874mk1vb9c dot fsf at igel dot home>
On 08/14/2015 01:57 PM, Andreas Schwab wrote:
> Faraz Shahbazker <faraz.shahbazker@imgtec.com> writes:
>
>> + if (__builtin_expect (GLRO(dl_debug_mask) & DL_DEBUG_SYMBOLS, 0))
>
> __builtin_expect -> __glibc_unlikely
>
>> + if (__builtin_expect (r_type == R_MIPS_IRELATIVE, 1))
>
> __builtin_expect -> __glibc_likely
Now that you've pointed it out, the local trend in sysdeps/mips is distinctly
in favour of __builtin_expect. If I have to use one of the two consistently
within the patch, it should be __builtin_expect.
Thanks,
Faraz Shahbazker