This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] time/tst-strptime2.c: test full input range +/- 0-9999

From: Mike Frysinger <vapier at gentoo dot org>
To: James Perkins <james at loowit dot net>
Cc: GNU libc <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, Paul Eggert <eggert at cs dot ucla dot edu>
Date: Sun, 16 Aug 2015 10:31:19 -0400
Subject: Re: [PATCH 2/2] time/tst-strptime2.c: test full input range +/- 0-9999
Authentication-results: sourceware.org; auth=none
References: <1439667772-16906-1-git-send-email-james at loowit dot net> <1439667772-16906-3-git-send-email-james at loowit dot net>

On 15 Aug 2015 12:42, James Perkins wrote:
> +static const char const *dummy_string = "1113472456";

the double const here doesn't make sense.  maybe you meant:
	static const char * const dummy_string = ...;

but really it looks like you want:
	static const char dummy_string[] = ...;

> +      extern bool verbose; \

you shouldn't need this since the code is all included below

> +      verbose = 1; \

verbose is a bool, so only use true & false.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH 2/2] time/tst-strptime2.c: test full input range +/- 0-9999
  - From: James Perkins

References:
- [PATCH v5 0/2] [BZ #16141] strptime %z: fix rounding, extend range
  - From: James Perkins
- [PATCH 2/2] time/tst-strptime2.c: test full input range +/- 0-9999
  - From: James Perkins

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]