This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ 2898] Mention mkdtemp as another secure alternative to mktemp


On Sun, Aug 09, 2015 at 11:34:31AM +0200, Gleb Fotengauer-Malinovskiy wrote:
> [BZ #2898]
> * misc/mktemp.c: Add mkdtemp to link_warning message.
> Patch by Aurelien Jarno.
> ---
>  misc/mktemp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/mktemp.c b/misc/mktemp.c
> index fc82ede..a144938 100644
> --- a/misc/mktemp.c
> +++ b/misc/mktemp.c
> @@ -33,4 +33,4 @@ __mktemp (template)
>  }
>  weak_alias (__mktemp, mktemp)
>  
> -link_warning (mktemp, "the use of `mktemp' is dangerous, better use `mkstemp'")
> +link_warning (mktemp, "the use of `mktemp' is dangerous, better use `mkstemp' or `mkdtemp'")

This line is too long.  Besides that, LGTM.


-- 
ldv

Attachment: pgpSYSmSUdRsT.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]