This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/5] Clean pthread functions namespaces for C11 threads
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Juan Manuel Torres Palma <j dot m dot torrespalma at gmail dot com>
- Cc: <libc-alpha at sourceware dot org>, Juan Manuel Torres Palma <jmtorrespalma at gmail dot com>
- Date: Thu, 13 Aug 2015 23:42:05 +0000
- Subject: Re: [PATCH 2/5] Clean pthread functions namespaces for C11 threads
- Authentication-results: sourceware.org; auth=none
- References: <1439217470-23427-1-git-send-email-j dot m dot torrespalma at gmail dot com> <1439217470-23427-3-git-send-email-j dot m dot torrespalma at gmail dot com>
On Mon, 10 Aug 2015, Juan Manuel Torres Palma wrote:
> @@ -501,7 +501,7 @@ allocate_stack (const struct pthread_attr *attr, struct pthread **pdp,
> size += pagesize_m1 + 1;
> #endif
>
> - mem = mmap (NULL, size, prot,
> + mem = __mmap (NULL, size, prot,
> MAP_PRIVATE | MAP_ANONYMOUS | MAP_STACK, -1, 0);
In cases such as this, you need to reindent followign lines of the call so
they remain correctly indented after the function name has got longer.
> +weak_alias(__pthread_cancel, pthread_cancel);
Missing space before '('.
--
Joseph S. Myers
joseph@codesourcery.com