This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] i386: Assembly Implementation cleanup
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 11 Aug 2015 17:22:19 -0700
- Subject: Re: [PATCH] i386: Assembly Implementation cleanup
- Authentication-results: sourceware.org; auth=none
- References: <5596AD3B dot 1060903 at linaro dot org>
On Fri, Jul 3, 2015 at 8:41 AM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> This patch removes i386 assembly implementation for epoll_wait, mmap,
> mmap64, semtimeop now that i386 have 6 argument syscall support from
> C code.
>
> The mmap implementation used is the wordsize-32 generic linux one.
>
> Tested in i386.
>
> ---
>
> * sysdeps/unix/sysv/linux/i386/mmap.c: New file.
> * sysdeps/unix/sysv/linux/i386/epoll_pwait.S: Remove file.
> * sysdeps/unix/sysv/linux/i386/mmap.S: Likewise.
> * sysdeps/unix/sysv/linux/i386/mmap64.S: Likewise.
> * sysdeps/unix/sysv/linux/i386/semtimedop.S: Likewise.
>
What is the motivation? 6 argument syscalls aren't really inlined.
They put arguments on stack and call __libc_do_syscall. It is
slower than assembly code.
--
H.J.