This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Readd O_LARGEFILE flag for openat64

From: Mike Frysinger <vapier at gentoo dot org>
To: Andreas Schwab <schwab at suse dot de>
Cc: libc-alpha at sourceware dot org
Date: Mon, 10 Aug 2015 11:13:33 -0400
Subject: Re: [PATCH] Readd O_LARGEFILE flag for openat64
Authentication-results: sourceware.org; auth=none
References: <mvmegjbmh5i dot fsf at hawking dot suse dot de>

On 10 Aug 2015 15:01, Andreas Schwab wrote:
> +	  error (0, 0, "openat64 is not supported");

shouldn't all of these error() calls be printf ?  error() writes to stderr.
maybe test-skeleton.c should close stderr and dupe stdout to it ?

not that it's a regression -- this test uses it a lot.  so lgtm as-is.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH] Readd O_LARGEFILE flag for openat64
  - From: Andreas Schwab

References:
- [PATCH] Readd O_LARGEFILE flag for openat64
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]