This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.22 -- Final testing for 32-bit x86 failing?
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 5 Aug 2015 08:46:36 -0700
- Subject: Re: glibc 2.22 -- Final testing for 32-bit x86 failing?
- Authentication-results: sourceware.org; auth=none
- References: <55BD1D92 dot 6040406 at redhat dot com> <CAMe9rOr3fOZK_PUt-pEqivGi2h3qmSaQaKLipN7LG8VgB45D7A at mail dot gmail dot com> <CALoOobPwKv003N5BMcPQ+QThRkfpk9s5Ev86srZa+JuCSvf6DA at mail dot gmail dot com> <55C1B80F dot 8040702 at redhat dot com>
On Wed, Aug 5, 2015 at 12:15 AM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 08/01/2015 06:27 PM, Paul Pluzhnikov wrote:
>> The following trivial patch fixes this:
>
> LGTM for 2.23, which is now open. Falls under the obvious category
> for including a header for a function you use.
Hmm, for some reason I can't reproduce this anymore, and unistd.h is
already included indirectly.
I don't understand why that's happening. But it still seems like a
good idea from header hygiene perspective.
--
Paul Pluzhnikov