This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Another GLIBC build error with GCC6


On 08/04/2015 05:10 PM, Paul Eggert wrote:
On 08/04/2015 01:28 PM, Richard Henderson wrote:
I believe you can just change L to UL and it should all Just Work.

Yes, though it's still confusing code.  A better approach is in:

https://sourceware.org/ml/libc-alpha/2015-07/msg00713.html

Sure.

Probably a formulation like #define DT_EXTRATAGIDX(tag) ((tag) - (DT_HIPROC -
DT_EXTRANUM)) would be a lot better. And understandable, from a "what the
hell is this trying to do" standpoint. r~

Right idea, though that particular formulation looks backwards -- see Andreas's
suggestion as codified in:

https://sourceware.org/ml/libc-alpha/2015-07/msg00742.html

It isn't backward, in that it retains the current indexing.

If reversing the indexing is considered ok, then that's (sightly) better. But even then, using DT_FILTER isn't best, whereas DT_HIPROC is.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]